search

dwyl / learn-tdd

:white_check_mark: A brief introduction to Test Driven Development (TDD) in JavaScript (Complete Beginner's Step-by-Step Tutorial)
Mozilla Public License 2.0
2.75k stars 346 forks source link

Adding Explanation of introducing a Regression when doing TDD #125

Closed mattdrago closed 5 years ago

mattdrago commented 5 years ago

This change will add text to the README.md that describes the introduction of a regression and how to fix it. The base test of no change required has also been added to the test.js and all images have been updated to include this test as well.

This resolves https://github.com/dwyl/learn-tdd/issues/124

codecov[bot] commented 5 years ago

Codecov Report

Merging #125 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #125   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          33     37    +4     
=====================================
+ Hits           33     37    +4
Impacted Files Coverage Δ
test.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e53a25...75cb64d. Read the comment docs.

mattdrago commented 5 years ago

Thanks @nelsonic, I'm glad that you liked it and merged it in to the master. Thanks for the tip on the binaries.