theodowling commented 5 years ago

Resolve issue #90

I've also updated dependencies and fixed some credo warnings.

nelsonic commented 5 years ago

Travis-CI build appears to fail because app cannot connect to Postgres ...

connection refused - :econnrefused

https://travis-ci.org/dwyl/library/builds/593206304#L428

nelsonic commented 5 years ago

Going to restart/rerun the build on this PR and see if it passes in light of: #94 (added postgres) ...

nelsonic commented 5 years ago

@theodowling looks like the PR won't pass CI until you either rebase on master or add the lines:

services: # ensure that Travis-CI provisions a DB for our tests
  - postgresql

to the .travis.yml file.

https://travis-ci.org/dwyl/library/builds/593679274#L466

Thanks for the PR BTW! 🥇

codecov[bot] commented 5 years ago

Codecov Report

Merging #91 into master will decrease coverage by 1.09%. The diff coverage is n/a.

@@           Coverage Diff            @@
##           master     #91     +/-   ##
========================================
- Coverage     100%   98.9%   -1.1%     
========================================
  Files          17      17             
  Lines         270     274      +4     
========================================
+ Hits          270     271      +1     
- Misses          0       3      +3

Impacted Files	Coverage Δ
lib/library_web/controllers/login_controller.ex	`93.33% <0%> (-6.67%)`	:arrow_down:
lib/library_web/views/component_view.ex	`98.27% <0%> (-1.73%)`	:arrow_down:
lib/library_web/controllers/plugs/set_user.ex	`100% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8dda00a...6b7e7c7. Read the comment docs.

theodowling commented 5 years ago

Thanks for the tip @nelsonic - rebasing resolved the travis issue.

dwyl / library

Update credo dependency to fix warning #91

Codecov Report