dwyl / phoenix-liveview-todo-list-tutorial

✅ Beginners tutorial building a Realtime Todo List in Phoenix 1.6.10 + LiveView 0.17.10 ⚡️ Feedback very welcome!
https://liveview-todo.herokuapp.com/
69 stars 11 forks source link

Chores/deprecate mix config #143

Closed sharkby7e closed 11 months ago

sharkby7e commented 11 months ago

Mix test now runs clean without deprecation warnings:

warning: Mix.Config.config/3 is deprecated. Use the Config module instead
  config/test.exs:8

warning: Mix.Config.config/3 is deprecated. Use the Config module instead
  config/test.exs:17

warning: Mix.Config.config/2 is deprecated. Use the Config module instead
  config/test.exs:22

warning: the :phoenix compiler is no longer required in your mix.exs.

Please find the following line in your mix.exs and remove the :phoenix entry:

    compilers: [..., :phoenix, ...] ++ Mix.compilers(),

  (phoenix 1.7.10) lib/mix/tasks/compile.phoenix.ex:8: Mix.Tasks.Compile.Phoenix.run/1
  (mix 1.15.5) lib/mix/task.ex:447: anonymous fn/3 in Mix.Task.run_task/5
  (mix 1.15.5) lib/mix/tasks/compile.all.ex:124: Mix.Tasks.Compile.All.run_compiler/2
  (mix 1.15.5) lib/mix/tasks/compile.all.ex:104: Mix.Tasks.Compile.All.compile/4
  (mix 1.15.5) lib/mix/tasks/compile.all.ex:93: Mix.Tasks.Compile.All.with_logger_app/2
  (mix 1.15.5) lib/mix/tasks/compile.all.ex:56: Mix.Tasks.Compile.All.run/1

Generated live_view_todo app
warning: :logger :level has been set to :warn in config files, please use :warning instead
  (logger 1.15.5) lib/logger/app.ex:102: Logger.App.default_level/0
  (logger 1.15.5) lib/logger/app.ex:35: Logger.App.start/2
  (kernel 9.0.2) application_master.erl:293: :application_master.start_it_old/4
warning: Phoenix.Controller.get_flash/2 is deprecated. get_flash/2 is deprecated. Use Phoenix.Flash.get(@flash, key) instead
Invalid call found at 2 locations:
  lib/live_view_todo_web/templates/layout/app.html.heex:2: LiveViewTodoWeb.LayoutView."app.html"/1
  lib/live_view_todo_web/templates/layout/app.html.heex:3: LiveViewTodoWeb.LayoutView."app.html"/1
sharkby7e commented 11 months ago

includes changes from https://github.com/dwyl/phoenix-liveview-todo-list-tutorial/pull/142

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ad53f79) 100.00% compared to head (78d4f72) 100.00%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #143 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 6 6 Lines 80 80 ========================================= Hits 80 80 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.