search

dwyl / phoenix-liveview-todo-list-tutorial

✅ Beginners tutorial building a Realtime Todo List in Phoenix 1.6.10 + LiveView 0.17.10 ⚡️ Feedback very welcome!
https://liveview-todo.herokuapp.com/
69 stars 11 forks source link

Status links with LiveView #22

Closed SimonLab closed 2 years ago

SimonLab commented 2 years ago

Filter items by status ref: https://github.com/dwyl/phoenix-liveview-todo-list-tutorial#9-footer-navigation

codecov[bot] commented 2 years ago

Codecov Report

Merging #22 (dc708ab) into master (9022926) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head dc708ab differs from pull request most recent head abc8af5. Consider uploading reports for the commit abc8af5 to get more accurate results

@@            Coverage Diff            @@
##            master       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           30        37    +7     
=========================================
+ Hits            30        37    +7
Impacted Files Coverage Δ
lib/live_view_todo_web/live/page_live.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9022926...abc8af5. Read the comment docs.

SimonLab commented 2 years ago

Getting back to this PR. I need to make sure the features are still working then add tests to boost the coverage

SimonLab commented 2 years ago

@nelsonic this PR is now ready for review, thanks :+1: