dwyl / sendemail

💌 Simplifies reliably sending emails from your node.js apps using AWS Simple Email Service (SES)

181 stars 26 forks source link

Removes line 19 from index.js. #35

Closed Conorc1000 closed 8 years ago

Conorc1000 commented 8 years ago

This stops dir from being reassigned and the module can find the template directory.

32

naazy commented 8 years ago

The tests were failing because the template_directory in the travis ci env variables was incorrectly saved as ../examples/templates instead of ./examples/templates. This has been changed on travis ci and tests are now passing with 100% coverage :fireworks:

codecov-io commented 8 years ago

Current coverage is 100%

Merging #35 into master will not change coverage

@@           master   #35   diff @@
===================================
  Files           1     1          
  Lines          34    33     -1   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
- Hits           34    33     -1   
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last updated by f20e6c1...d0ec8b7

nelsonic commented 8 years ago

@naazy please bump the version in package.json to 2.1.0 so we can re-publish with the fix. ping me when updated. thanks. 👍

naazy commented 8 years ago

Done @nelsonic :+1:

nelsonic commented 8 years ago

Thanks. merging.

nelsonic commented 8 years ago

New version published to npm: sendemail@2.1.0 thanks again @Conorc1000 & @naazy ✨