dwyl / sendemail

💌 Simplifies reliably sending emails from your node.js apps using AWS Simple Email Service (SES)
181 stars 26 forks source link

Add note to readme on not using fake email addresses #49

Closed iteles closed 7 years ago

iteles commented 7 years ago

When fake email addresses are used (i.e. for automated tests), it's incredibly easy to hit SES' limit of bounced emails and be blocked by the service.

I suggest we add a note to the readme to warn people of this.

samhstn commented 7 years ago

Another way to avoid this problem is to stub out emails being sent, doing so will mean you can have as many automated tests in your code as you like without worrying about hitting email limits.

(It will also drastically speed up your tests)

samhstn commented 7 years ago

I'm happy to write up a section about good practices for automated testing when using this as a third party library. After #56 has been addressed

otajor commented 7 years ago

@shouston3 this would be super useful.