dwyl / sendemail

💌 Simplifies reliably sending emails from your node.js apps using AWS Simple Email Service (SES)
182 stars 26 forks source link

Users should be able to specify charset #76

Closed roryc89 closed 7 years ago

roryc89 commented 7 years ago

As a user of this library I would like to be able to specify the charset used in my body and subject. This would allow me to use utf16 instead of utf8 and avoid issues with non standard characters.

iteles commented 7 years ago

@roryc89 Could we default to utf16 so this is never a question? Are there downsides?

roryc89 commented 7 years ago

@iteles some people think so : http://softwareengineering.stackexchange.com/questions/102205/should-utf-16-be-considered-harmful http://utf8everywhere.org/

But I have a very limited understanding of this and I don't know if the issues mentioned in these sites apply to this context.

Perhaps best to keep defaulting to utf-8 for now?

nelsonic commented 7 years ago

@roryc89 new version published to NPM: sendemail@3.3.0 thanks! 👍

roryc89 commented 7 years ago

closing as implemented :)