contextual clue on from name/email

dwyl / sendemail

💌 Simplifies reliably sending emails from your node.js apps using AWS Simple Email Service (SES)

182 stars 26 forks source link

contextual clue on from name/email #82

Closed ryanburnette closed 6 years ago

ryanburnette commented 6 years ago

PR

I had to check the source to figure out how to set a name to go along with the sender name. This is just an update in the readme that demonstrates that.

Misc

If the sender email parameter is required in the ENV, there should be a way to set it there. You can't do that with env2, maybe you can on Heroku or a local environment. Or maybe with env2 and json.

Also, I don't think it should be required if it's set in the options.

nelsonic commented 6 years ago

Note: the reason the PR does not pass on Travis-CI is because the PR is not on a branch. Happy to merge as no code has been changed. 👍