Closed nelsonic closed 4 years ago
Build fails because nyc
is using let
:
https://travis-ci.org/dwyl/sendemail/builds/649045383#L407
Need to update the version of node
in .travis.yml
to latest. π
Merging #95 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #95 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 43 38 -5
=====================================
- Hits 43 38 -5
Impacted Files | Coverage Ξ | |
---|---|---|
lib/index.js | 100% <100%> (ΓΈ) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update b35dbe2...0bae080. Read the comment docs.
@iteles this is a maintenance release but it adds package-lock.json
which is huge. π
It's 100% backward compatible with previous versions. π―
But since I've updated the minimum Node.js
requirements to v12 (latest/LTS), π
I'm releasing a major version: 4.0.0
. π¦
Please review & merge when you can. π
Thanks! β¨
Read all about it: https://github.com/dwyl/sendemail/tree/improve-maintainability-issue%2394
This PR is a general tidy up. I have not changed the code/interface beyond a minor refactor for maintainability. see: #94