dwyl / sendemail

💌 Simplifies reliably sending emails from your node.js apps using AWS Simple Email Service (SES)

182 stars 26 forks source link

PR: Improve Maintainability #95

Closed nelsonic closed 4 years ago

nelsonic commented 4 years ago

This PR is a general tidy up. I have not changed the code/interface beyond a minor refactor for maintainability. see: #94

nelsonic commented 4 years ago

Build fails because nyc is using let: https://travis-ci.org/dwyl/sendemail/builds/649045383#L407

Need to update the version of node in .travis.yml to latest. 📝

codecov[bot] commented 4 years ago

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          43     38    -5     
=====================================
- Hits           43     38    -5

Impacted Files	Coverage Δ
lib/index.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b35dbe2...0bae080. Read the comment docs.

nelsonic commented 4 years ago

@iteles this is a maintenance release but it adds package-lock.json which is huge. 🙄 It's 100% backward compatible with previous versions. 💯 But since I've updated the minimum Node.js requirements to v12 (latest/LTS), 🏇 I'm releasing a major version: 4.0.0. 📦
Please review & merge when you can. 🙏 Thanks! ✨

nelsonic commented 4 years ago

Read all about it: https://github.com/dwyl/sendemail/tree/improve-maintainability-issue%2394