search

dwyl / smart-home-auth-server

The authorisation server for dwyl/smart-home-security-system
GNU General Public License v2.0
5 stars 1 forks source link

24 Tests Fail on Master Branch #15

Closed nelsonic closed 3 years ago

nelsonic commented 3 years ago

Hi @th0mas, hope your morning is going well. I tried to run the tests on the master branch of this project on my localhost and I get the following error:

image

Appears to be related to the feature flags. 💭

This is matches what we see on Travis-CI where the last few builds have failed: https://travis-ci.com/github/dwyl/smart-home-auth-server/branches image

The most recent master build is: https://travis-ci.com/github/dwyl/smart-home-auth-server/builds/178230954#L892 image

Please take a look at the failing tests and ensure that they all pass on master (create a branch/PR to fix the tests) and let me know when it's done so I can proceed with the Heroku deployment #14 Thanks. ✨

th0mas commented 3 years ago

@nelsonic Yeah I was delaying rewriting the tests until the authorization system properly working with RBAC as ~60% of the tests and systems will be affected by this. I'm happy to try and fix the tests that are broken now but I won't aim for a high coverage until RBAC is complete and I know how much of the hub needs to be adapted

th0mas commented 3 years ago

Theres a few bugs in the smart hub (#7, #11) that need to be fixed before a "production" release of this but will be rewritten/significantly changed to work with RBAC in the future.

nelsonic commented 3 years ago

Ah ... OK. If this is dependent on RBAC, please see/answer https://github.com/dwyl/smart-home-auth-server/issues/1#issuecomment-670448196 ❓ I will switch back to RBAC now and focus on that. 👍

th0mas commented 3 years ago

Its not RBAC dependent per se, and there's still a few broken tests from #7 that I'll fix now and I'll comment out all the authorization tests for now so we can get deployment working.

But most of the tests will rely on a RBAC implementation so we'll probably only end up with 30-40% coverage for now.

nelsonic commented 3 years ago

@th0mas OK. if that's the case, fix the tests you can fix (as you've said) and if we can get master in a stable/deployable state even with low coverage I will get that done today so that you can use the Heroku instance in the firmware tests. 👍