Open th0mas opened 3 years ago
@nelsonic If you could go through this code so far for anything that you disagree with/think could be done better that would be great
Merging #27 into master will decrease coverage by
2.05%
. The diff coverage is67.85%
.
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 57.56% 55.50% -2.06%
==========================================
Files 26 27 +1
Lines 205 218 +13
==========================================
+ Hits 118 121 +3
- Misses 87 97 +10
Impacted Files | Coverage Δ | |
---|---|---|
lib/smart_home_auth.ex | 100.00% <ø> (ø) |
|
lib/smart_home_auth/access/door.ex | 100.00% <ø> (ø) |
|
lib/smart_home_auth_web/channels/lock_channel.ex | 31.57% <0.00%> (-1.76%) |
:arrow_down: |
...smart_home_auth_web/controllers/door_controller.ex | 73.33% <57.14%> (-26.67%) |
:arrow_down: |
lib/smart_home_auth_web/views/door_view.ex | 90.00% <66.66%> (-10.00%) |
:arrow_down: |
lib/smart_home_auth_web/controllers/rbac_auth.ex | 75.00% <75.00%> (ø) |
|
lib/smart_home_auth_web/controllers/user_mapper.ex | 66.66% <75.00%> (ø) |
|
lib/smart_home_auth/access.ex | 100.00% <100.00%> (ø) |
|
lib/smart_home_auth/account/user.ex | 100.00% <100.00%> (ø) |
|
lib/smart_home_auth_web/router.ex | 27.27% <100.00%> (+7.27%) |
:arrow_up: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f19dde7...1b04dd4. Read the comment docs.
Integrate RBAC into smart home.
TODO:
check/1
to use roles - Blocked