search

dwyl / smart-home-firmware

Firmware for dwyl/smart-home-security-system
GNU General Public License v3.0
4 stars 0 forks source link

Fix and update tests #11

Closed th0mas closed 4 years ago

th0mas commented 4 years ago

Aiming for 85%+ Coverage

codecov[bot] commented 4 years ago

Codecov Report

Merging #11 into master will increase coverage by 15.41%. The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #11       +/-   ##
===========================================
+ Coverage   43.41%   58.82%   +15.41%     
===========================================
  Files          12       12               
  Lines         129      136        +7     
===========================================
+ Hits           56       80       +24     
+ Misses         73       56       -17
Impacted Files Coverage Ξ”
lib/smart_home_firmware/lock/lock.ex 36.36% <25.00%> (-4.82%) :arrow_down:
lib/smart_home_firmware/client/hub_client.ex 68.75% <60.00%> (+40.48%) :arrow_up:
lib/smart_home_firmware/feature_manager.ex 83.33% <0.00%> (+50.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update a62312c...8644d6c. Read the comment docs.

th0mas commented 4 years ago

This is as far as we can get as far as unit testing the hub. Coverage should go up once we have implemented #13

nelsonic commented 4 years ago

Still getting intermittent build (test) failure: https://travis-ci.com/github/dwyl/smart-home-firmware/builds/178730311#L561 image

Going to restart the build and see if it passes. 🀞 This should be addressed as part of #13

nelsonic commented 4 years ago

After re-running the build two tests fail instead of one ... lol. image

This definitely needs to be addressed.

All tests pass on the 4th run on travis:

https://travis-ci.com/github/dwyl/smart-home-firmware/builds/178730311#L538 image

@th0mas ideally we wouldn't have any warnings either. πŸ’­

th0mas commented 4 years ago

4 of those warnings are my fault, however two are due to a wrong behaviour specification in the PN532 library. I'll file an issue in that repo

nelsonic commented 4 years ago

@th0mas yeah, it's always good to have a trail of why things are the way they are in the issues. πŸ‘ Otherwise great work, keep it up! πŸ™Œ