search

dwyl / smart-home-firmware

Firmware for dwyl/smart-home-security-system
GNU General Public License v3.0
4 stars 0 forks source link

Including hub server for integration tests #14

Closed th0mas closed 4 years ago

th0mas commented 4 years ago

Includes the features detailed in #13

codecov[bot] commented 4 years ago

Codecov Report

Merging #14 into master will increase coverage by 1.47%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   58.82%   60.29%   +1.47%     
==========================================
  Files          12       12              
  Lines         136      136              
==========================================
+ Hits           80       82       +2     
+ Misses         56       54       -2
Impacted Files Coverage Δ
lib/smart_home_firmware/client/hub_client.ex 72.91% <0.00%> (+4.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd65581...f3e96ed. Read the comment docs.

nelsonic commented 4 years ago

@th0mas hopefully you can use the Heroku version of the Hub/Auth server https://github.com/dwyl/smart-home-auth-server/pull/19 for this. 🤞

th0mas commented 4 years ago

Fixed in an alternative way in dwyl/smart-home-auth-server#14

nelsonic commented 4 years ago

@th0mas a lot of the detail in this PR is not captured anywhere and you spent a decent chunk of time exploring it. If we ever need to run multiple apps on Travis-CI again, it could be worth having this documented somewhere. e.g: a run-multiple-apps.md in https://github.com/dwyl/learn-travis 💭