Switch to `phoenix_gen_socket_client`

dwyl / smart-home-firmware

Firmware for dwyl/smart-home-security-system

GNU General Public License v3.0

4 stars 0 forks source link

Closed th0mas closed 4 years ago

th0mas commented 4 years ago

We probably want to switch our Phoenix socket client out for a few reasons:

phoenix_gen_socket_client has a TestSocket that means we can run integration tests against this library
More complete documentation
lower level OTP model that will work better for our use case

th0mas commented 4 years ago

Implemented in 0459086.

Also took this opportunity to refractor the hub client so its a bit nicer to understand now

nelsonic commented 4 years ago

@th0mas great simplification. 🙌