Closed Cleop closed 7 years ago
:exclamation: No coverage uploaded for pull request base (
master@1efaaae
). Click here to learn what that means. The diff coverage is53.84%
.
@@ Coverage Diff @@
## master #10 +/- ##
=========================================
Coverage ? 53.84%
=========================================
Files ? 5
Lines ? 13
Branches ? 0
=========================================
Hits ? 7
Misses ? 6
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
web/views/error_helpers.ex | 0% <0%> (ø) |
|
web/controllers/page_controller.ex | 100% <100%> (ø) |
|
test/support/conn_case.ex | 100% <100%> (ø) |
|
web/views/error_view.ex | 100% <100%> (ø) |
|
web/router.ex | 50% <50%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1efaaae...13e4b61. Read the comment docs.
@Cleop the objective with this project is not to overwhelm beginners with thoughts that they need to know Elixir/Phoenix in order to use Tachyons. We want complete beginners to be able to use and understand the code in here. if we are using .eex
templates instead of "plain" .html
we will quickly "lose" people. remember our aim is broad appeal.
We can always re-use this for the dwyl-styleguide
where we can totally use Phoenix because it's an internal tool.
Please git push
your branch to: https://github.com/dwyl/style-guide so it isn't "lost" (it's a good setup just over-complicated for this
project)
see: https://github.com/dwyl/learn-phoenix-framework/issues/81#issuecomment-303374085
for sample project structure.
and please let me know if you want to pair on it at any point. 👍