dwyl / tachyons-bootstrap

👢Bootstrap recreated using tachyons functional css
http://tachyons-bootstrap.dwyl.com
48 stars 4 forks source link

Tidy up for public release #50

Closed Cleop closed 7 years ago

Cleop commented 7 years ago

Tackles issues from #43 broken into separate issues:

codecov[bot] commented 7 years ago

Codecov Report

Merging #50 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #50   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          21     29    +8     
  Branches        5      7    +2     
=====================================
+ Hits           21     29    +8
Impacted Files Coverage Δ
component_combiner.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be14053...5ea6f17. Read the comment docs.

iteles commented 7 years ago

Odd. Tried to run this branch and localhost just hangs.

Will try again tomorrow after I try to shut down my computer overnight. Might be a local thing.

Cleop commented 7 years ago

Changes now made. Please now review @iteles and let me know if you encounter any more problems! @katbow please amend your review if you're happy.

katbow commented 7 years ago

@Cleop Can a test be added for the additions to component_combiner.js? That should keep it at 100% 🙂 💃

Cleop commented 7 years ago

Opps! Sorry for missing that. Here we go! @katbow