Closed azlam-abdulsalam closed 1 year ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
7c5d9d4
) 46.80% compared to head (e336f46
) 46.86%.:exclamation: Current head e336f46 differs from pull request most recent head 38fdf45. Consider uploading reports for the commit 38fdf45 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
paths are matched with includes rather than checking the directory properly. This can result in packages being built if the directory structure is similar
fixes #1396
Summary generated by Reviewpad on 13 Oct 23 11:41 UTC
This pull request fixes an issue where packages are built incorrectly when the path to the package starts with the same structure. Instead of properly checking the directory, paths were matched using includes, which could result in packages being built even if the directory structure was only similar. The patch modifies the PackageDiffImpl.ts file to properly check the directory structure before building packages. Additionally, a new test case is added in the PackageDiffImpl.test.ts file to verify the fix.
Checklist
All items have to be completed before a PR is merged