search

dxc-technology / Hanlon-Microkernel

A small (in-memory) Microkernel used by the Hanlon server for discovery of new nodes
Other
20 stars 21 forks source link

cpu_vendor tag uses wrong fact #33

Closed hickey closed 8 years ago

hickey commented 8 years ago

Just realized that the system defined cpu_vendor tag is incorrect. cpu_vendor is defined as:

cpu_vendor    {mk_hw_bus_vendor}        N/A                     sys

If I look at the output of the attributes being reported back, I think that mk_hw_cpu0_vendor should be used rather than mk_hw_bus_vendor. Here are the values being reported back. 

    mk_hw_bus_description       Motherboard
    mk_hw_bus_physical_id       0
    mk_hw_bus_product           X10DRT-P
    mk_hw_bus_serial            ZM15BS030591
    mk_hw_bus_vendor            Supermicro
    mk_hw_bus_version           1.10
    mk_hw_cpu0_bus_info         cpu@0
    mk_hw_cpu0_capacity         4GHz
    mk_hw_cpu0_clock            100MHz
    mk_hw_cpu0_description      CPU
    mk_hw_cpu0_physical_id      77
    mk_hw_cpu0_product          Xeon
    mk_hw_cpu0_size             1223MHz
    mk_hw_cpu0_slot             CPU1
    mk_hw_cpu0_vendor           Intel Corp.
    mk_hw_cpu0_width            64 bits
    mk_hw_cpu1_bus_info         cpu@1
    mk_hw_cpu1_capacity         4GHz
    mk_hw_cpu1_clock            100MHz
    mk_hw_cpu1_description      CPU
    mk_hw_cpu1_physical_id      7b
    mk_hw_cpu1_product          Xeon
    mk_hw_cpu1_size             1316MHz
    mk_hw_cpu1_slot             CPU2
    mk_hw_cpu1_vendor           Intel Corp.
    mk_hw_cpu1_width            64 bits
    mk_hw_cpu_count             2
hickey commented 8 years ago

Maybe have a new tag called sys_vendor? Or board_vendor?

hickey commented 8 years ago

Sorry, looking back at this just a moment ago I realized that this should have been created as a Hanlon issue. I will close this and create it over there.