Select bottom border line is very thin(thick) compare to date and input components

dxc-technology / halstack-angular

A CDK for building SPAs with Angular and Halstack Design System

https://developer.dxc.com/tools/angular/next/#/overview

Apache License 2.0

10 stars 17 forks source link

Select bottom border line is very thin(thick) compare to date and input components #369

Open apallamreddy opened 3 years ago

apallamreddy commented 3 years ago

Describe the bug The select bottom border line is vert thin(thick) compare to other components date & input Expected behavior the select bottom border should be same tick as other components(date & input ) Screenshots Screenshot (152) Screenshot (154)

mchaudhary5 commented 3 years ago

Please provide ETC for this issue.

apallamreddy commented 3 years ago

Can you conform in which version this issue is fixed We have updated the Version to 3.0.3 but still getting the issue. when screen is 100% Screenshot (180)

mawelCaballero commented 3 years ago

Fix done in "@dxc-technology/halstack-angular": "3.0.4"

aidamag commented 3 years ago

You can check the fix here: https://codesandbox.io/s/test-input-1n7d1?file=/src/app/app.component.html

apallamreddy commented 3 years ago

Hi @Lisa159 , I have installed latest version 3.0.4 but still issue exit can you check in different resolution 100,90,110 you can see the issue Screenshot (192) Screenshot (193) Screenshot (194)

Jialecl commented 3 years ago

Hello @apallamreddy ,

You are right, when zooming in the underlines do look different. A new fix is on the way.

mawelCaballero commented 3 years ago

@Jialecl has been working on it and it has been fixes in this "next" version. @dxc-technology/halstack-angular@0.0.0-42addec

Can you test it and give us feedback? In case of your feedback is positive a new release version will be created.

apallamreddy commented 3 years ago

Hi @Jialecl , After installing latest next version components like input,data & select, are state behaving entirely differently (Not working fine Screenshot (214) Screenshot (215) Screenshot (216) )

jsardid commented 3 years ago

I don't know what you mean by "not working fine". Can you be more specific?

Have in mind that if you are upgrading from another major version, there might be breaking changes in the components' API. We are following semver and you can find the changelog here: https://github.com/dxc-technology/halstack-angular/releases

apallamreddy commented 3 years ago

Hi @jsardid , You can see in The screen shot I have attached which is circled select bottom line is tick for same select fields not for all select field even though they are same component we use CDK Select , same for input field
Screenshot (216)_LI

jsardid commented 3 years ago

@apallamreddy This is only happening with some screen resolutions. We are looking into it.

mchaudhary5 commented 3 years ago

What is the suggested resolution.

jsardid commented 3 years ago

After talking to @apallamreddy, we have realised that this issue only happens if the user has rescaling enabled in the OS or in the browser.

Since:

The impact of the issue is low: in the unlikely scenario of a user with rescaling enabled, the issue only consists in the bottom line of some of the input fields being displayed 1px thicker.
Fixing it will take a considerable amount of time (we are not even sure of how to fix it right now), since this is related to underlying material fields using decimal pixels.
We are about to re-implement the inputs from scratch in the following weeks, with new designs and without material, which will fix the issue.

We have decided not to fix it right now and wait for the re-implementation that will happen the next weeks.