[x] Build process is done without errors and all tests pass in the /lib directory.
[x] Self-reviewed the code before submitting.
[x] Meets accessibility standards.
[x] Added/updated documentation to /website as needed.
[x] Added/updated tests as needed.
Description
As described in the linked issue, an error was spotted at the Dialog when using Jest and having to render this component. After some research, this problem was related to a nwsapi problem, which is a library used by Jest jsdom.
So, to fix this, the aria-disabled selector was removed from the tabbable elements query at the FocusLock component. Apart from solving this problem, the change is motivated by the fact that aria-disabled is a semantic attribute, i.e. it has no functionality on the component. Therefore, excluding elements with this attribute from the list of tabbable elements of the focus lock is unnecessary.
Also, I did npm install in the lib folder and I can see a new dependency added into the package-lock.json. I think it would be a good idea to update it.
Checklist
/lib
directory./website
as needed.Description As described in the linked issue, an error was spotted at the Dialog when using Jest and having to render this component. After some research, this problem was related to a nwsapi problem, which is a library used by Jest
jsdom
.So, to fix this, the aria-disabled selector was removed from the tabbable elements query at the
FocusLock
component. Apart from solving this problem, the change is motivated by the fact thataria-disabled
is a semantic attribute, i.e. it has no functionality on the component. Therefore, excluding elements with this attribute from the list of tabbable elements of the focus lock is unnecessary.Additional context Issue: https://github.com/dperini/nwsapi/issues/81
Closes #1586