dxc-technology / halstack-react

Library of components for building SPAs with React and Halstack Design System
https://developer.dxc.com/halstack/
Apache License 2.0
15 stars 14 forks source link

Chip's specs tokens are not synchro with the implementation #1610

Open GomezIvann opened 1 year ago

GomezIvann commented 1 year ago

While implementing a fix for the Chip component I noticed that the tokens of the current implementation are not matching the ones established on the specifications page of the component. This is a problem since the user can get confused when, for example, creating an advanced theme.

The task here is to review all the tokens of the component and synchronize implementation with the specs page.

image

image

  chip: {
    backgroundColor: CORE_TOKENS.color_grey_200,
    disabledBackgroundColor: CORE_TOKENS.color_grey_100,
    fontFamily: CORE_TOKENS.type_sans,
    fontSize: CORE_TOKENS.type_scale_03,
    fontStyle: CORE_TOKENS.type_normal,
    fontWeight: CORE_TOKENS.type_regular,
    fontColor: CORE_TOKENS.color_black,
    disabledFontColor: CORE_TOKENS.color_grey_500,
    borderColor: CORE_TOKENS.color_transparent,
    borderRadius: "80px",
    borderThickness: CORE_TOKENS.border_width_0,
    borderStyle: CORE_TOKENS.border_solid,
    contentPaddingLeft: "16px",
    contentPaddingRight: "16px",
    contentPaddingTop: "0px",
    contentPaddingBottom: "0px",
    iconSize: "24px",
    iconSpacing: "8px",
    iconColor: CORE_TOKENS.color_grey_800,
    hoverIconColor: CORE_TOKENS.color_grey_900,
    activeIconColor: CORE_TOKENS.color_black,
    disabledIconColor: CORE_TOKENS.color_grey_500,
    focusColor: CORE_TOKENS.color_blue_600,
    focusBorderStyle: CORE_TOKENS.border_solid,
    focusBorderThickness: CORE_TOKENS.border_width_2,
    focusBorderRadius: CORE_TOKENS.border_radius_medium,
  }
github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

raquelarrojo commented 5 months ago

Fix available here: https://github.com/dxc-technology/halstack-react/tree/rarrojolopez/chip-fixes https://github.com/dxc-technology/halstack-react/tree/rarrojolopez/chip-specs

It has been reverted to avoid creating a breaking change.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.