Describe the bug
When installing a project that includes "@dxc-technology/halstack-react": "^9.1.0" and "react": "^18.2.0" as dependencies, you get several conflicts due to @radix-ui/react-popover@0.1.6.
npm WARN While resolving: @radix-ui/react-popover@0.1.6
npm WARN Found: react-dom@18.2.0
npm WARN node_modules/react-dom
npm WARN peer react-dom@"^16.8 || ^17.0" from @radix-ui/react-portal@0.1.4
npm WARN node_modules/@diaas/assure-platform-react-tools/node_modules/@radix-ui/react-popover/node_modules/@radix-ui/react-portal
npm WARN @radix-ui/react-portal@"0.1.4" from @radix-ui/react-popover@0.1.6
npm WARN node_modules/@diaas/assure-platform-react-tools/node_modules/@radix-ui/react-popover
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react-dom@"^16.8 || ^17.0" from @radix-ui/react-popover@0.1.6
npm WARN node_modules/@dxc-technology/halstack-react/node_modules/@radix-ui/react-popover
npm WARN @radix-ui/react-popover@"0.1.6" from @dxc-technology/halstack-react@9.1.0
npm WARN node_modules/@dxc-technology/halstack-react
npm WARN
npm WARN Conflicting peer dependency: react-dom@17.0.2
npm WARN node_modules/react-dom
npm WARN peer react-dom@"^16.8 || ^17.0" from @radix-ui/react-popover@0.1.6
npm WARN node_modules/@dxc-technology/halstack-react/node_modules/@radix-ui/react-popover
npm WARN @radix-ui/react-popover@"0.1.6" from @dxc-technology/halstack-react@9.1.0
It seems that react-popover@0.1.6 is pinned in Halstack-react
Taking a look at that popover version, it seems that it's not React 18 compatible:
There is no final 0.1.7 release, so I tried with the last candidate version available. I tested it with CSAM Release Service UI and CSAM Environment Service UI with no issues during test executions or manual tests (at least for now... 😄).
Use "--legacy-peer-deps"
It's my second option, because this parameter will affect to the whole amount of dependencies and I want to use that functionality from npm 7+.
Add labels
Add any applicable label like the concerned components or the target version of the Design System where the bug has been found.
Describe the bug When installing a project that includes "@dxc-technology/halstack-react": "^9.1.0" and "react": "^18.2.0" as dependencies, you get several conflicts due to @radix-ui/react-popover@0.1.6.
It seems that react-popover@0.1.6 is pinned in Halstack-react
Taking a look at that popover version, it seems that it's not React 18 compatible:
And Halstack-react requires React 18:
To Reproduce
Expected behaviour No conflicts when using halstack-react >=9 and react 18.
Screenshots If applicable, add screenshots to help explain your problem.
Additional context Taking a look at the possible solutions:
There is no final 0.1.7 release, so I tried with the last candidate version available. I tested it with CSAM Release Service UI and CSAM Environment Service UI with no issues during test executions or manual tests (at least for now... 😄).
It's my second option, because this parameter will affect to the whole amount of dependencies and I want to use that functionality from npm 7+.
Add labels Add any applicable label like the concerned components or the target version of the Design System where the bug has been found.