dxc-technology / halstack-react

Library of components for building SPAs with React and Halstack Design System
https://developer.dxc.com/halstack/
Apache License 2.0
15 stars 14 forks source link

DxcTextInput - have option for Prefix where it has divider ( | ) sign which is confusing, Couldn't find any option to remove the same #1742

Closed mjayaraj2 closed 3 months ago

mjayaraj2 commented 10 months ago

Is your feature request related to a problem? Please describe. In DxcTextInput component, we have option for Prefix where it has divider ( | ) sign which is confusing, Couldn't find any option to remove the same. In US, they always use like this $ 10,000.00 . Need provision to remove the divider

Describe the solution you'd like There should be provision to remove the divider ( | ) sign

Describe alternatives you've considered Customizing the DxcTextInput which is not the preferrable

Additional context There should be provision to remove the divider ( | ) sign

Add Labels Add any applicable labels like related components, services, team or project reporting this new feature... etc.

DxcTextInputWithDivider

kukoc commented 10 months ago

Hi @mjayaraj2 , Thanks for reaching out.

Having a divider is a design decision that Halstack Designers can probably justify with arguments like accessibility or readability. I will let them to comment

lcordobapuerto commented 10 months ago

Hello @mjayaraj2,

As Aitor mentioned before, the decision to include a divider in our Text Input, in this case, responds to design needs in terms of usability. The presence of a divider that separates the prefix/suffix from the actual value helps the user to differentiate the format (whether they are item numbers or currencies) and creates a hierarchy between the prefix and the value to be entered.

Moreover, in this use case, the presence of the divider does not alter the intended result. In both cases (with or without divider) it is understood that the value entered is $ 10,000.00.

Thanks for reaching out!

kukoc commented 10 months ago

More feedback from Janice:

From a business perspective, the divider bar is very distracting on an entry field. Since we are a financial system, amount entry fields are prevalent in our views. As a user, the divider is confusing and distracts from the dollar prefix.

We would really appreciate it if you would reopen this and provide an ability to show/hide any dividers.

Thanks!

lcordobapuerto commented 10 months ago

Hi there! As we've stated before, the presence of a divider in the prefix/suffix in our Text input is supported by a design decision to improve the overall user experience and usability of said component. However, we understand that using a divider in a prefix/suffix of a currency is a special use case, which is why we're collecting all your valuable inputs to evaluate the possible future addition of an Amount component to Halstack. In addition, we're always glad to receive contributions, so if you have something in mind, we'll be happy to consider your inputs for this possible new component. Thank you!

GomezIvann commented 8 months ago

As there has been no further activity, this issue is closed.

lcordobapuerto commented 4 months ago

Hey there! We have been thinking about this issue for a while now, do you think this approach could work for you? Can you please check with your team that this is what you are looking for? NI - no divider Thank you!

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

kukoc commented 3 months ago

@mjayaraj2 , please share your feedback. Thanks

mjayaraj2 commented 3 months ago

Yes, would prefer to see as below DxcTextInputDollarsign

GomezIvann commented 3 months ago

Yes, would prefer to see as below DxcTextInputDollarsign

Hello again,

This image does not correspond to our designers' proposal, but we will do our best to meet your needs. I will work on it.

Thanks!