dxc-technology / halstack-react

Library of components for building SPAs with React and Halstack Design System
https://developer.dxc.com/halstack/
Apache License 2.0
15 stars 14 forks source link

Fixing typing for the whole Select component #1766

Closed Mil4n0r closed 9 months ago

Mil4n0r commented 10 months ago

Checklist

Description Removed ts-nocheck and fixed the problems related to it. Also typed all the methods and variables.

Additional context A few small changes to logic were made in order to allow a better readibility and, overall, cleaner code. Also removed redundant types (SingleSelect and MultipleSelect could be merged into one type).

Closes #1555

GomezIvann commented 9 months ago

One last comment, the code is unformatted. Can you please install the code formatter we use in Halstack in your Visual Studio Code IDE?

Name: Prettier - Code formatter Id: esbenp.prettier-vscode Description: Code formatter using prettier Version: 10.1.0 Publisher: Prettier VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode

Mil4n0r commented 9 months ago

Thanks for the detailed review Iván! I just added the requested changes 😄

GomezIvann commented 9 months ago

Great job Enrique, this was a tough one!