Remove `BackgroundColorProvider` from Halstack

dxc-technology / halstack-react

Library of components for building SPAs with React and Halstack Design System

https://developer.dxc.com/halstack/

Apache License 2.0

15 stars 14 forks source link

Remove `BackgroundColorProvider` from Halstack #1774

Closed GomezIvann closed 8 months ago

GomezIvann commented 8 months ago

Checklist

[x] The Build process is done without errors. All tests pass in the /lib directory.
[x] Self-reviewed the code before submitting.
[x] Meets accessibility standards.
[x] Added/updated documentation to /website as needed.
[x] Added/updated tests as needed.

Description Our design tokens are currently under review, and our future way of implementing the Dark Theme will likely be very different from the current one. Until we figure out how to properly build a hierarchy of tokens. This functionality is going to be in the shadows.

Jialecl commented 8 months ago

There is a visual test for the container that can be removed, since it is testing the container with a black background.

Jialecl commented 8 months ago

We still have references to onDark in the color page, the advanced theme example and the advanced theme generator. Should we consider removing those in this PR?

GomezIvann commented 8 months ago

We still have references to onDark in the color page, the advanced theme example and the advanced theme generator. Should we consider removing those in this PR?

The Color Usage Page is removed in another PR (https://github.com/dxc-technology/halstack-react/pull/1750) and the theme generator needs to be updated in a separate one (it requires a new version of the library with the tokens removed). Otherwise, the app would crush.