Added new `StatusLight` component

dxc-technology / halstack-react

Library of components for building SPAs with React and Halstack Design System

https://developer.dxc.com/halstack/

Apache License 2.0

15 stars 14 forks source link

Added new `StatusLight` component #1804

Closed Mil4n0r closed 9 months ago

Mil4n0r commented 9 months ago

Checklist (Check off all the items before submitting)

[x] Build process is done without errors. All tests pass in the /lib directory.
[x] Self-reviewed the code before submitting.
[x] Meets accessibility standards.
[x] Added/updated documentation to /website as needed.
[x] Added/updated tests as needed.

Description Implementing the new StatusLight component, including testing and documentation.

Closes #1803

Mil4n0r commented 9 months ago

Only the basic documentation for the website was done. Design part and basic usage are still missing. (It is possible to create a new task for it)

GomezIvann commented 9 months ago

An observation on this PR and for the next time. When we develop a new component we normally do the implementation first and then the documentation in a separate PR. This alleviates the burden of the review, allows the task to be broken down into smaller modules and also has the benefit that once the implementation has been merged, a new version of the library is generated and can therefore be used in the documentation PR for the examples.

raquelarrojo commented 9 months ago

Also, developers are only in charge of the Code tab. Usage and Specifications are created by the designers in most of the cases, since they are who best know its usage and specs.