Closed Mil4n0r closed 6 months ago
The context files should not be located in the layout folder.
The context files should not be located in the layout folder.
I agree, I did it because there was already the SideNav context there, but it does not make that much sense.
We should discuss what the appropiate location would be. In my opinion the lib/src/[component]/ directory is fine(maybe adding a context/ additional folder inside).
We should discuss what the appropiate location would be. In my opinion the lib/src/[component]/ directory is fine(maybe adding a context/ additional folder inside).
I think in the lib/src/[component]/
is the correct path there is no need to add an additional level to the path.
Checklist
/lib
directory./website
as needed.Description While reviewing #1854, we discovered that there were multiple circular dependencies inside the project which, in some scenarios, could cause issues.
In this PR, we are fixing the remaining ones that are:
To address those issues, I have moved the logic related to the respective contexts (which were the ones causing the circular dependencies) outside the component file, following the same pattern that was used for
SideNavContext
.