dxc-technology / halstack-react

Library of components for building SPAs with React and Halstack Design System
https://developer.dxc.com/halstack/
Apache License 2.0
15 stars 14 forks source link

New SideNav structure #1933

Closed Mil4n0r closed 5 months ago

Mil4n0r commented 6 months ago

Checklist

Description The previous HTML structure of the SideNav was very poor in terms of semantics.

Closes #1642

Mil4n0r commented 6 months ago

Required feedback from the rest of the team.

There is still one problem to address. Section compound component is now treated as a ul, however, there are some scenarios where its child is a paragraph or any other text. In my opinion, we should create a specific compound component regarding that scenario. (For example TextSection) in case we don't want to lose that functionality, another more opinionated option would be to simply force the user to use list items as children. (Which is generally the correct case scenario for a SideNav)

Mil4n0r commented 5 months ago

Closed for now until the topic is discussed.