Use custom `DxcTooltip` instead of default HTML tooltip in Halstack Components

dxc-technology / halstack-react

Library of components for building SPAs with React and Halstack Design System

https://developer.dxc.com/halstack/

Apache License 2.0

15 stars 14 forks source link

Use custom `DxcTooltip` instead of default HTML tooltip in Halstack Components #1965

Closed Mil4n0r closed 4 months ago

Mil4n0r commented 5 months ago

Checklist

[x] Build process is done without errors. All tests pass in the /lib directory.
[x] Self-reviewed the code before submitting.
[x] Meets accessibility standards.
[ ] Added/updated documentation to /website as needed.
[x] Added/updated tests as needed.

Related to PR #1965

GomezIvann commented 5 months ago

Hello Enrique!

But have you already implemented the component without making the API call after the corresponding research and drafting? You need to share first your proposal with the team before starting the development phase! We can discuss this offline.

Mil4n0r commented 5 months ago

Yes, I wanted to leave this as a draft until the discussion but it definitely made things easier for me to do the implementation first in order to make sure it covered all the possible scenarios.

After the logic is validated I will open it back.

Mil4n0r commented 5 months ago

I added a few comments to clarify certain topics and propose additional modifications. Waiting for review.