dxc-technology / halstack-react

Library of components for building SPAs with React and Halstack Design System
https://developer.dxc.com/halstack/
Apache License 2.0
15 stars 14 forks source link

Fix `DxcLink` border radius #2039

Closed Mil4n0r closed 1 month ago

Mil4n0r commented 2 months ago

Checklist (Check off all the items before submitting)

Description For consistency purposes, the border-radius of the Link component is 2px and we want to update it to 4px. This is its value in most of our components.

Additional context Even though it was listed as 2px, the images used were using border-radius: 4px internally. That is why it is only required to change the first image in the Specifications tab.

Closes #1719

Mil4n0r commented 2 months ago

I have yet to ask for the specs image with the 2px padding added.

Mil4n0r commented 2 months ago

All images have been updated.

Mil4n0r commented 1 month ago

One comment, comparing the component with the designs and the specs images I still think the component is too tall. Maybe we need to adjust this by updating the line-height, what do you think? Maybe we need Lara or Irene's help.

image

I missed that, but I agree with you that it is too tall. Using 100% line-height for the anchor seems to look just like in the images.