search

dxc-technology / online-devops-dojo

DevOps hands-on learning modules in your browser
https://dxc-technology.github.io/about-devops-dojo/
Mozilla Public License 2.0
61 stars 32 forks source link

Need assistance with module version-control #58

Closed mboedker closed 4 years ago

mboedker commented 4 years ago

How do I open data.sql ?

I tried to write open data.sql but nothing happens.

pberthonneau commented 4 years ago

I guess you are in step 3 or 4 of Continuous integration module.

Head over to your copy of the Pet Clinic application on GitHub, and navigate to the file in the src/main/resources/db/hsqldb folder named data.sql

If you click on src/main/resources/db/hsqldb link you'll see on the right the GitHub links page with the link to your own data.sql highlighted. Click on it, scroll up to see the pencil and follow the instructions to make the change. Once you're done, in step 4 you'll scroll down the data.sql page and complete the Commit changes form.

Let me know if you have a concern or close this issue. Thanks for attending the Online DevOps Dojo!

mboedker commented 4 years ago

Hi

I have now added line 24 to data.sql:

[cid:image001.png@01D642EC.19CF4F20]

And saved the changes, but when I follow the steps in DevOps Dojo VersionControl, it says that there are nothing to commit and everything is up to date:

[cid:image002.png@01D642EC.19CF4F20]

So if I press “Continue”, I don’t have a “Pull request” in GitHub for “Horse”.

What am I doing wrong ?

Med venlig hilsen

Michael Bødker Senior Developer DXC Eclipse, Northern Europe

M: +45 2060 9727 mboedker@dxc.commailto:mboedker@dxc.com

From: Philippe Berthonneau notifications@github.com Sent: Thursday, 11 June 2020 15.00 To: dxc-technology/online-devops-dojo online-devops-dojo@noreply.github.com Cc: Boedker, Michael mboedker@dxc.com; Author author@noreply.github.com Subject: Re: [dxc-technology/online-devops-dojo] Need assistance with module version-control (#58)

I guess you are in step 3 of 8 of Continuous integration module.

Head over to your copy of the Pet Clinic application on GitHub, and navigate to the file in the src/main/resources/db/hsqldb folder named data.sql

If you click on src/main/resources/db/hsqldb link you'll see on the right the GitHub links page with the link to your own data.sql highlighted. Click on it, scroll up to see the pencil and follow the instructions to make the change.

Let me know if you have a concern or close this issue. Thanks for attending the Online DevOps Dojo!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://clicktime.symantec.com/3BVkZFtfwVmrxDHGHv36Bp47Vc?u=https%3A%2F%2Fgithub.com%2Fdxc-technology%2Fonline-devops-dojo%2Fissues%2F58%23issuecomment-642631390, or unsubscribehttps://clicktime.symantec.com/3MWpDtEyKQuchEzBKWLVKFq7Vc?u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAP5C3BINAVKGYJEA67LWPQTRWDILTANCNFSM4N3E2HCA.

DXC Technology Company -- This message is transmitted to you by or on behalf of DXC Technology Company or one of its affiliates. It is intended exclusively for the addressee. The substance of this message, along with any attachments, may contain proprietary, confidential or privileged information or information that is otherwise legally exempt from disclosure. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient of this message, you are not authorized to read, print, retain, copy or disseminate any part of this message. If you have received this message in error, please destroy and delete all copies and notify the sender by return e-mail. Regardless of content, this e-mail shall not operate to bind DXC Technology Company or any of its affiliates to any order or other contract unless pursuant to explicit written agreement or government initiative expressly permitting the use of e-mail for such purpose.

pberthonneau commented 4 years ago

You have no difference between your working branch and master branch, this is why you cannot create a new PR.

Actually your master branch has already the change line #24, which means that you committed your change directly in master, which is not a good practice when you want a peer review (which is the case here). Then I guess you went off rails from step 3 instructions.

I advise you to revert the change on your master:

then close and forget your branches https://github.com/mboedker/pet-clinic/branches, except master. Then restart from the beginning of step 3.

If you don't succeed you can also delete the pet-clinic repository (from tab setting) and replay the Welcome.

pberthonneau commented 4 years ago

In lack of answer, I'm closing this. Re-open if needed.