dxc-technology / online-devops-dojo

DevOps hands-on learning modules in your browser
https://dxc-technology.github.io/about-devops-dojo/
Mozilla Public License 2.0
61 stars 32 forks source link

Introduced Dojo Octocat in Welcome Module #85

Closed tom-halpin closed 3 years ago

tom-halpin commented 3 years ago

Proposed changes

In response to https://github.com/dxc-technology/online-devops-dojo/issues/83 introduced Dojo Octocat in Welcome modle

Types of changes

What types of changes does your code introduce to Online DevOps Dojo? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

tom-halpin commented 3 years ago

People are not free to take modules in any order. I had precised in the intro of few modules that they depend on others (and not only on welcome).

ok I will correct that note

tom-halpin commented 3 years ago

He's a cool cat. 😆 Note, the octocat.gif is not used in the PR; is it needed?

He's a cool cat. 😆 Note, the octocat.gif is not used in the PR; is it needed?

the original format is gif, but most of the images in the dojo are png so included both for completeness

tom-halpin commented 3 years ago

People are not free to take modules in any order. I had precised in the intro of few modules that they depend on others (and not only on welcome).

ok I will correct that note

done

tom-halpin commented 3 years ago

He's a cool cat. 😆 Note, the octocat.gif is not used in the PR; is it needed?

He's a cool cat. 😆 Note, the octocat.gif is not used in the PR; is it needed?

the original format is gif, but most of the images in the dojo are png so included both for completeness

done