dxc-technology / online-devops-dojo

DevOps hands-on learning modules in your browser
https://dxc-technology.github.io/about-devops-dojo/
Mozilla Public License 2.0
61 stars 32 forks source link

Fixed issue running prepare.sh in version control module #95

Closed tom-halpin closed 3 years ago

tom-halpin commented 3 years ago

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Online DevOps Dojo? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

tom-halpin commented 3 years ago

@ojacques @pberthonneau this is to address https://github.com/dxc-technology/online-devops-dojo/issues/94

tom-halpin commented 3 years ago

@pberthonneau I observed the same behaviors, and suspected this was a Katacoda change. I also thought about changing the uieditorpath setting, but thought the change I proposed was the one that had the smallest risk of unwanted side effects