search

dxe / adb

Activist Database Project
11 stars 5 forks source link

Geocoding on activist update #197

Closed jefftienchow closed 1 year ago

jefftienchow commented 1 year ago

Attempt at geocoding addresses with google API on activist update

Tested locally on a variety of addresses. Google Geocoding API has a bit undefined behavior when entering bogus addresses but seems to work well with real addresses.

Not sure if I should include package-lock.json changes in my commits?

jakehobbs commented 1 year ago

Thanks for this! I will review later today.

alexsapps commented 1 year ago

Me too, ty and will check it out!

Le mar. 2 mai 2023, 09:49, jakehobbs @.***> a écrit :

Thanks for this! I will review later today.

— Reply to this email directly, view it on GitHub https://github.com/dxe/adb/pull/197#issuecomment-1531811328, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS6DL7KDYYOF5CEM33GVILXEE3J3ANCNFSM6AAAAAAXSUA7TI . You are receiving this because your review was requested.Message ID: @.***>

alexsapps commented 1 year ago

Not sure if I should include package-lock.json changes in my commits?

Yes, maintaining package-lock.json changes in version control ensures reproducible builds. package.json only specifies a range of versions allowed to build the project, not exact versions.