search

dxfjs / writer

A JavaScript dxf generator written in TypeScript.
https://dxf.vercel.app
MIT License
83 stars 17 forks source link

Stringify Performance #25

Closed hschmiedhofer closed 2 years ago

hschmiedhofer commented 2 years ago

Hi,

for some automation stuff i am working on, i did a quick test-run of your very nice package. My intention is to compose a DXF from several sub-drawings, which already works nicely. These sub-drawings can become quite detailed, though. My current test-setup parses and inserts entities from an 8MB DXF into an instance of your writer class, which is real quick.

However, for the final write-to-disc, i need to stringify(), which unfortunately takes about 30sec.

Do you think there's a way of speeding things up here?

tarikjabiri commented 2 years ago

Hi

I will investigate, 30s is a lot. I need an example to reproduce.

hschmiedhofer commented 2 years ago

I will investigate, 30s is a lot. I need an example to reproduce.

Thank you so much! I sent you the zipped example project via your email.

tarikjabiri commented 2 years ago

Hi, Now it's about 2s please check (v2.0.8) and close this issue if you are satisfied. regards

hschmiedhofer commented 2 years ago

It's even quicker than that here! Thanks a lot, @tarikjabiri ! :)

tarikjabiri commented 2 years ago

@hschmiedhofer very nice 🎉❤