dxfjs / writer

A JavaScript dxf generator written in TypeScript.
https://dxf.vercel.app
MIT License
83 stars 17 forks source link

missmatched hatches #59

Closed mhkim-swk closed 1 year ago

mhkim-swk commented 1 year ago

Hi

when i try to plot Predefined "CROSS" hatch, but result was "CORK"

some other hatches were missmatched too.

in your code https://github.com/dxfjs/writer/blob/fd22b111d49ff6805dc7d75550c748e6ebbda006/src/Internals/HatchPatterns.ts#L957:L990 135 degree lines are not required in cross pattern

please check this part, thanks!

mhkim-swk commented 1 year ago

image

tarikjabiri commented 1 year ago

Hi,

Those pre-defined I auto generate them and I didn't test them, I am planing to get rid of them an make a way to define the pattern manually.

And add examples in docs so people can copy what they need only. Because there's a lot of code shipped in the package and people don't use all of them or not using them at all.

Actually do you need them all.

mhkim-swk commented 1 year ago

@tarikjabiri It should be good thats enough if user can define pattern. i tried to find define custom pattern, but it seems impossible in currernt version.

thank you for comment! happy new year