dxfjs / writer

A JavaScript dxf generator written in TypeScript.
https://dxf.vercel.app
MIT License
82 stars 17 forks source link

feat: add arc dimension entity #76

Closed FishOrBear closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (08cf5f5) 93.54% compared to head (32fc705) 93.54%.

:exclamation: Current head 32fc705 differs from pull request most recent head b9299dd. Consider uploading reports for the commit b9299dd to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ======================================= Coverage 93.54% 93.54% ======================================= Files 74 74 Lines 7658 7658 Branches 527 527 ======================================= Hits 7164 7164 Misses 494 494 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tarikjabiri commented 1 year ago

Hi,

Thank you for your contribution.

But there is no such entity ARC_DIMENSION in dxf spec, is this working did you test it

FishOrBear commented 1 year ago

arc_dim.zip

Yes, I have tested it, you can open it with acad2004 or above. There is indeed no such entity in the dxf document, I don't know why acad does not provide this document.