dxfjs / writer

A JavaScript dxf generator written in TypeScript.
https://dxf.vercel.app
MIT License
82 stars 17 forks source link

fix: avoid viewport height of 0 #78

Closed FishOrBear closed 1 year ago

FishOrBear commented 1 year ago

https://github.com/dxfjs/writer/pull/77

When we don't provide Entity's Box function correctly, we hope that it will not make an error, and give a 200 to avoid ACAD not being able to open the file.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (08cf5f5) 93.54% compared to head (562dab4) 93.54%.

:exclamation: Current head 562dab4 differs from pull request most recent head 8ccfc60. Consider uploading reports for the commit 8ccfc60 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ======================================= Coverage 93.54% 93.54% ======================================= Files 74 74 Lines 7658 7658 Branches 527 528 +1 ======================================= Hits 7164 7164 Misses 494 494 ``` | [Impacted Files](https://codecov.io/gh/dxfjs/writer/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs) | Coverage Δ | | |---|---|---| | [.../Sections/TablesSection/Tables/Records/DxfVPort.ts](https://codecov.io/gh/dxfjs/writer/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs#diff-c3JjL1NlY3Rpb25zL1RhYmxlc1NlY3Rpb24vVGFibGVzL1JlY29yZHMvRHhmVlBvcnQudHM=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.