search

dxing97 / subs2cia

Condensed Immersive Audiovisual media generator from subtitles for language learning
MIT License
89 stars 10 forks source link

Subs2Cia omitting some subtitle lines #31

Open spirited1086 opened 1 year ago

spirited1086 commented 1 year ago

Just noticed that subs2cia will omit some lines when parsing an srt subtitle file, e.g., in my case there were a lot of or tags and those lines were omitted when condensing. The resuting condensed audio was a mess. I removed all the tags and it's working. Is this a feature? if so what other kind of characters should I search for and remove from subtitle files to allow for propery condensation?

dxing97 commented 11 months ago

Yes, there's a built in filter for removing suspected non-dialogue subtitle lines. You can check out the relevant code here. If it's not working with your files you can disable it with -ni and optionally use your own regex instead with -R.