dxli / quarticSolver

Find real roots for real quartic equations
3 stars 2 forks source link

bug in the code... #1

Open stiv-yakovenko opened 7 years ago

stiv-yakovenko commented 7 years ago

this gives a crash:

double a[]={2.0000000000025215, 1.5000000000025215, 0.5, -0.0625};
double r[5];
quarticSolver(a,r);
dxli commented 7 years ago

Hi stiv,

Please note this quartic solver is outdated, and is there only for explanatory purposes.

If you are interested in some mature quartic solver code, please have a look at the Eigen library's polynomial solver, and one example can be found at:

https://github.com/LibreCAD/LibreCAD_3/blob/master/lckernel/cad/math/lcmath.cpp#L124

Best Regards,

Dongxu

On Thu, Aug 18, 2016 at 1:57 AM, stiv-yakovenko notifications@github.com wrote:

this gives a crash:

double a[]={2.0000000000025215, 1.5000000000025215, 0.5, -0.0625}; double r[5]; quarticSolver(a,r);

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dxli/quarticSolver/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AAygIdNhN1ZAv69th0YQyHr1uZVtTfIoks5qg_QvgaJpZM4JnKI0 .

Dongxu Li, Ph.D.