dxos-deprecated / dashboard

DxOS Dashboard
MIT License
0 stars 1 forks source link

Local services being requested for IPFS page #45

Closed ccamrobertson closed 4 years ago

ccamrobertson commented 4 years ago

On the IPFS page, the local service path is still being requested rather than the route:

Screen Shot 2020-04-13 at 8 56 55 PM

I believe that this is the primary responsible line that needs to be migrated to getServiceUrl along with the hostname: https://github.com/dxos/dashboard/blob/523db3f958c4348a38e8b1be3d26022367dad8be/src/pages/console/ipfs.js#L69

I suspect that the following function also requires an update: https://github.com/dxos/dashboard/blob/523db3f958c4348a38e8b1be3d26022367dad8be/src/pages/console/ipfs.js#L120

ccamrobertson commented 4 years ago

To clarify, in this image 127.0.0.1/$X is being requested when xbox.local/$X should be requested.

ccamrobertson commented 4 years ago

https://github.com/dxos/dashboard/pull/47