See images below for comparison; this seems to be due to an explicit local flag which is checking for localhost or 127.0.0.1. In the case of xbox.local, this will fail. Without further rationale on why logs should be blocked for xbox's, I recommend that we either remove the flag or change the local behavior.
telackey
commented
4 years ago
See images below for comparison; this seems to be due to an explicit
localflag which is checking forlocalhostor127.0.0.1. In the case ofxbox.local, this will fail. Without further rationale on why logs should be blocked for xbox's, I recommend that we either remove the flag or change thelocalbehavior.With logs:
Without logs:
See:
https://github.com/dxos/dashboard/blob/cf5da1ba0597296cdaad993d43b420691b244518/src/lib/util.js#L36
https://github.com/dxos/dashboard/blob/cf5da1ba0597296cdaad993d43b420691b244518/src/hooks/registry.js#L26
https://github.com/dxos/dashboard/blob/cf5da1ba0597296cdaad993d43b420691b244518/src/pages/console/wns.js#L281