search

dxos-deprecated / dashboard

DxOS Dashboard
MIT License
0 stars 1 forks source link

Fix app urls #54

Closed ccamrobertson closed 4 years ago

ccamrobertson commented 4 years ago

The app URL scheme on the app page is close, but not quite right; it should point to /app/$publicUrl:

Screen Shot 2020-04-14 at 7 49 37 PM

Loading apps is also dependent on https://github.com/dxos/dashboard/issues/51.

telackey commented 4 years ago

I know this came up in the status, but I'm slightly confused, because that link looks exactly like how it was described that it should look in the call the other day.

What is the "correct" link and how does one know it?

@AFDudley

ccamrobertson commented 4 years ago

The "working" way is linking to /app/$publicUrl as described by @elmasse in this issue: https://github.com/dxos/xbox/issues/72

This may be distinct from the "correct" way. My goal is a working stable build of xbox instead of blocking this deliverable on a new wire app serve.

elmasse commented 4 years ago

@ccamrobertson actually not /app/$publicUrl, the publicUrl already contain /app for now till we figure out how to properly set publicUrls bound to the app version urls.

ccamrobertson commented 4 years ago

@elmasse Ok, so $publicUrl is currently /app/$name? So really dashboard should just show "$publicUrl" without anything else.