search

dxos-deprecated / echo

Eventually Consistent Hierarchical Objects Database
GNU Affero General Public License v3.0
0 stars 1 forks source link

No `stream[Symbol.asyncIterator]` in browser #101

Open dmaretskyi opened 4 years ago

dmaretskyi commented 4 years ago

image

To reproduce run storybook in #99 experimental/echo-demo package

tinchoz49 commented 4 years ago

the solution is to add this packages in echo-protocol

"@types/readable-stream": "^2.3.9",
"readable-stream": "^3.6.0",

and replace https://github.com/dxos/echo/blob/3e48cbc378110eaca3211afd47ea6b8baa33e606/experimental/echo-protocol/src/feeds/feed-store-iterator.ts#L7 stream for readable-stream

I try to commit this changes in burdon/demo but I got: 

husky > pre-commit (node v12.18.1)
  ↓ Stashing changes... [skipped]
    → No partially staged files found...
  ❯ Running linters...
    ❯ Running tasks for *.ts
      ✖ eslint --cache --fix

✖ eslint --cache --fix found some errors. Please fix them and try committing again.

Oops! Something went wrong! :(

ESLint: 7.7.0

ESLint couldn't find the plugin "eslint-plugin-node".

(The package "eslint-plugin-node" was not found when loaded as a Node module from the directory "dxos/echo/experimental/echo-protocol".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-node@latest --save-dev

The plugin "eslint-plugin-node" was referenced from the config file in "experimental/echo-protocol/.eslintrc.js » eslint-config-semistandard » eslint-config-standard".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.
husky > pre-commit hook failed (add --no-verify to bypass)