search

dxos-deprecated / echo

Eventually Consistent Hierarchical Objects Database
GNU Affero General Public License v3.0
0 stars 1 forks source link

fix: fire party.update event when party properties are changed on HAL… #349

Closed telackey closed 3 years ago

telackey commented 3 years ago

…O as well

telackey commented 3 years ago

This fixes two issues:

  1. We need to emit party.update() after tweaking global party preferences.
  2. We need to be able to call PartyInternal.open()/close() and arrive at working state.

The fix for (1) involves passing the PartyInternal object, rather than the key, to the PartyActivator. That way it can call party.update.emit().

The fix for (2) involves moving much of the logic regarding the pipelines, streams, etc. out of PartyFactory.constructParty() and into PartyInternal.open() so that it can be repeated if the party is closed, but later needs reopened again.