peerId - causing odd assertion

alexwykoff commented 3 years ago

Problem: In Teamwork an assertion error is repeatedly being displayed :

Uncaught (in promise) AssertionError: false == true
    at getPeerId (https://apollo1.kube.moon.dxos.network/app/wrn%3A%2F%2Fdxos%2Fapplication%2Fteamwork%40alpha/dxos~5983779d.bundle.js:29408:21)
    at GreetingCommandPlugin._removePeer (https://apollo1.kube.moon.dxos.network/app/wrn%3A%2F%2Fdxos%2Fapplication%2Fteamwork%40alpha/dxos~5983779d.bundle.js:29549:39)
    at Extension._close (https://apollo1.kube.moon.dxos.network/app/wrn%3A%2F%2Fdxos%2Fapplication%2Fteamwork%40alpha/dxos~5983779d.bundle.js:11276:20)
    at async NanoresourcePromise.[processpromise] (https://apollo1.kube.moon.dxos.network/app/wrn%3A%2F%2Fdxos%2Fapplication%2Fteamwork%40alpha/vendor~402f6fec.bundle.js:34952:7)

It appears to be the result of peerId being undefined in : https://github.com/dxos/halo/blob/5928f3cc2f3d7458e4373e8fc9a3e5b38c16a80b/packages/credentials/src/greet/greeting-command-plugin.ts#L29

Requested Solutions:

[ ] Confirm if this is genuinely an error or just an odd data hiccup.
[ ] Change the return to be single, peerId instead of multiple.
```
return {
peerId,
peerIdStr: peerId && keyToString(peerId)
```

alexwykoff commented 3 years ago

Sentry report is here : http://sentry.kube.dxos.network:9000/organizations/sentry/issues/368/?query=is%3Aunresolved

rzadp commented 3 years ago

Same issue: https://github.com/dxos/arena/issues/114

telackey commented 3 years ago

How to reproduce?

rzadp commented 3 years ago

@telackey See recording in https://github.com/dxos/arena/issues/114 - it seems to be happening randomly. Also we saw it today so it is still out there.

dxos-deprecated / halo

peerId - causing odd assertion #118