canary build fails

[dboreham]

This also happens on master if you delete yarn.lock:

$ eslint 'src/**/*.{ts,js}'
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

lerna ERR! yarn run lint stderr:

Oops! Something went wrong! :(

ESLint: 7.10.0

Error: package.json » plugin:@dxos/recomended:
        Configuration for rule "import/order" is invalid:
        Value {"pathGroups":[{"pattern":"@material-ui/**","group":"external","position":"after"},{"pattern":"@{dxos,wirelineio}/**","group":"internal","position":"before"}],"pathGroupsExcludedImportTypes":["@{dxos,wirelineio}/**","@material-ui/**"],"newlines-between":"always","groups":[["builtin","external"],"internal"],"alphabetize":{"order":"asc"}} should NOT have additional properties.

    at validateRuleOptions (/home/david/projects/wireline/halo/node_modules/eslint/lib/shared/config-validator.js:144:19)
    at /home/david/projects/wireline/halo/node_modules/eslint/lib/shared/config-validator.js:199:9
    at Array.forEach (<anonymous>)
    at validateRules (/home/david/projects/wireline/halo/node_modules/eslint/lib/shared/config-validator.js:196:30)
    at validateConfigArray (/home/david/projects/wireline/halo/node_modules/eslint/lib/shared/config-validator.js:324:9)
    at CascadingConfigArrayFactory._finalizeConfigArray (/home/david/projects/wireline/halo/node_modules/eslint/lib/cli-engine/cascading-config-array-factory.js:476:13)
    at CascadingConfigArrayFactory.getConfigArrayForFile (/home/david/projects/wireline/halo/node_modules/eslint/lib/cli-engine/cascading-config-array-factory.js:287:21)
    at FileEnumerator._iterateFilesRecursive (/home/david/projects/wireline/halo/node_modules/eslint/lib/cli-engine/file-enumerator.js:467:49)
    at _iterateFilesRecursive.next (<anonymous>)
    at FileEnumerator.iterateFiles (/home/david/projects/wireline/halo/node_modules/eslint/lib/cli-engine/file-enumerator.js:287:49)
error Command failed with exit code 2.

lerna ERR! yarn run lint exited 2 in '@dxos/credentials'
error Command failed with exit code 2.

[dboreham]

I'm going to take a look at fixing this.

[dboreham]

Possibly this: https://github.com/benmosher/eslint-plugin-import/issues/1621

[dboreham]

Problem is likely something to do with us picking up a year-old version of the package eslint-plugin-import that doesn't understand our new linting rule definition for ordered imports. This is a transitive dependency of the package semistandard and although we are also using an old version of that, the latest version is still referencing the old eslint-plugin-import.

DLL Hell reborn.

[telackey]

I fixed this dependency issue, but it didn't fix the build. Now it fails by (what looks to me) pulling the wrong echo-db/modelfactory:

https://github.com/dxos/halo/runs/1189927503?check_suite_focus=true

TypeError: this._partySettingsModel.createItem is not a function

[telackey]

Fixed by adding a "resolution" to make sure we don't try to draw in echo-db and model-factory canary builds (this party-manager needs old echo-db and old model-factory):

  "resolutions": {
    "@dxos/echo-db": "1.0.0-beta.28",
    "@dxos/model-factory": "1.0.0-beta.28"
  }

I only made this change in the canary branch, not master. Since master doesn't use our verdaccio, it doesn't need the resolution overridden.