dxos-deprecated / sdk

DXOS SDK and tools.
GNU Affero General Public License v3.0
0 stars 2 forks source link

`client.initialize` halts #229

Closed dmaretskyi closed 3 years ago

dmaretskyi commented 3 years ago

To reproduce:

  1. Checkout https://github.com/dxos/sdk/pull/227
  2. Run storybook in react-client

I've traced the error to be on this line - https://github.com/dxos/halo/blob/main/packages/credentials/src/keys/keystore.ts#L74. The promise there never resolves.

As a reference a storybook in dxos/echo/echo-demo can be used, which has practically the same code, but works.

telackey commented 3 years ago

Fixed my removing buggy process.nextTIck implementation:

https://github.com/dxos/sdk/commit/9bf0e6789b107eb1f0065cfe8219243fd0755637#diff-ef7c3e8f32284274351cdd677d5adf8444749e88b60f36a0a44930d0fe069d72L5