search

dxos-deprecated / sdk

DXOS SDK and tools.
GNU Affero General Public License v3.0
0 stars 2 forks source link

Test actions. #349

Closed richburdon closed 3 years ago

richburdon commented 3 years ago

Clean-up of actions. @Marik-D how can we standardize across repos?

The file below isn't generated?

          lcov-file: ./coverage/lcov.info # TODO(burdon): This file doesn't exist.
rzadp commented 3 years ago

lcov-file: ./coverage/lcov.info # TODO(burdon): This file doesn't exist.

About this - This was used at the beginning of introducing test coverage. This action commented a PR with coverage details (that's why it is run only on PRs).

It works only with lcov reporter, and I had trouble with c8 erroring out when attempting to generate this reporter, that's why we have another html reporter and this step of uploading lcov is not obsolete and removed in https://github.com/dxos/sdk/pull/350

dmaretskyi commented 3 years ago

@richburdon We can create our own actions for commons tasks like publishing & bumping the version https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/creating-a-composite-run-steps-action