search

dxos-deprecated / sdk

DXOS SDK and tools.
GNU Affero General Public License v3.0
0 stars 2 forks source link

GH Action clean-up #368

Closed richburdon closed 3 years ago

richburdon commented 3 years ago

@alexwykoff we should look into this before copying and pasting these actions to other repos:

https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/sharing-workflows-with-your-organization#creating-a-workflow-template

github-actions[bot] commented 3 years ago

Total Coverage: 23.36

Coverage report 

=============================== Coverage summary ===============================
Statements   : 23.36% ( 2350/10059 )
Branches     : 66.31% ( 246/371 )
Functions    : 49.18% ( 120/244 )
Lines        : 23.36% ( 2350/10059 )
================================================================================

github-actions[bot] commented 3 years ago

Total Coverage: 23.36

Coverage report 

=============================== Coverage summary ===============================
Statements   : 23.36% ( 2350/10059 )
Branches     : 66.31% ( 246/371 )
Functions    : 49.18% ( 120/244 )
Lines        : 23.36% ( 2350/10059 )
================================================================================

telackey commented 3 years ago

@richburdon push-tests should have a condition like here: https://github.com/dxos/tutorials/pull/62/files

The way it should fall out is this:

  1. Actions which integrate building, testing, and publishing on specific branches (main, beta, release).

  2. Actions which apply be default to all unpublished branches (eg, linting, building, testing).

We actually don't want too much overlap though, because we want to make sure that everything required to meet the conditions required for publishing (eg, all the tests passing) occurs in (1), since it is require to prevent publishing broken stuff, rather than presumed to be happening in some other action.

This distinction does complicate the naming pattern a bit though. The key distinction really is between published and unpublished branches, so it would be something like this:

publish-main.yml publish-beta.yml publish-release.yml test-unpublished.yml

alexwykoff commented 3 years ago

Closed #365 in favor of this PR.

There are currently two suggestions from that issue which I'm carrying over here to complete the conversation. Suggestions under consideration :

Verb + Target + Trigger (ex: build-lint-test-main-on-push.yml) Target + Verb (ex: main-build-lint-test.yml)

alexwykoff commented 3 years ago

Through consensus Verb + Target + Trigger (ex: build-lint-test-main-on-push.yml) was chosen as the naming convention for Github Actions.

github-actions[bot] commented 3 years ago

Total Coverage: 23.36

Coverage report 

=============================== Coverage summary ===============================
Statements   : 23.36% ( 2350/10059 )
Branches     : 66.13% ( 246/372 )
Functions    : 49.18% ( 120/244 )
Lines        : 23.36% ( 2350/10059 )
================================================================================

github-actions[bot] commented 3 years ago

Total Coverage: 23.36

Coverage report 

=============================== Coverage summary ===============================
Statements   : 23.36% ( 2350/10059 )
Branches     : 66.13% ( 246/372 )
Functions    : 49.18% ( 120/244 )
Lines        : 23.36% ( 2350/10059 )
================================================================================